Skip to content

Invert psql/package dependency logic #1179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2020
Merged

Invert psql/package dependency logic #1179

merged 1 commit into from
Jun 22, 2020

Conversation

raphink
Copy link
Contributor

@raphink raphink commented Jun 18, 2020

When instantiating several times the same PostgreSQL extension with the same
package name (e.g. pg_trgm and rh-postgresql10-postgresql-contrib.x86_64),
the current code leads to a duplicate declaration due to the clash on the
before parameter on the package passed through ensure_packages.

This PR inverts the logic to ensure that no require or before parameter is
passed to ensure_packages.

@raphink raphink requested a review from a team as a code owner June 18, 2020 12:27
@puppet-community-rangefinder
Copy link

postgresql::server::extension is a type

Breaking changes to this file WILL impact these 2 modules (exact match):
Breaking changes to this file MAY impact these 1 modules (near match):

This module is declared in 71 of 575 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@d24b17a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1179   +/-   ##
=========================================
  Coverage          ?   65.81%           
=========================================
  Files             ?       14           
  Lines             ?      351           
  Branches          ?        0           
=========================================
  Hits              ?      231           
  Misses            ?      120           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d24b17a...e7f9c9a. Read the comment docs.

@daianamezdrea
Copy link
Contributor

Hi @raphink, this looks good! Thank you for your contribution, I'll merge the PR!

@daianamezdrea daianamezdrea merged commit f0ca290 into puppetlabs:master Jun 22, 2020
cegeka-jenkins pushed a commit to cegeka/puppet-postgresql that referenced this pull request Feb 3, 2022
@daianamezdrea
Merge pull request puppetlabs#1179 from raphink/extension_package_dep
f0d6e5e 
Invert psql/package dependency logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@raphink @codecov-commenter @daianamezdrea @adrianiurca